On Sat, Apr 08, 2023 at 06:14:19AM +0300, Aleksandr Mezin wrote:
> On Thu, Apr 6, 2023 at 11:37 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> > -static const struct hwmon_channel_info *nzxt_smart2_channel_info[] = {
> > +static const struct hwmon_channel_info * const nzxt_smart2_channel_info[] = {
>
> In the rest of nzxt-smart2.c there are spaces only before "*", not on
> both sides (and there are a few "*const" already). Would be nice to
> keep it consistent. The same seems to be true for nzxt-kraken2.c
> (although I'm not a maintainer)
While I don't have a strong preference for either `* const` or `*const`,
it would be prefereable to use a single style in any given file.
As the kernel seems to favor the former style:
$ rg -F '*const ' | wc -l
2593
$ rg -F '* const ' | wc -l
15359
it would be better to change the other two locations in nzxt-kraken2.c
to also use `* const`.
