On 03/04/2023 17:43, Ibrahim Tilki wrote: > Devicetree binding documentation for Analog Devices MAX313XX RTCs > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@xxxxxxxxxx> > --- > .../devicetree/bindings/rtc/adi,max313xx.yaml | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml > new file mode 100644 > index 000000000..0c17a395e > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2022 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX313XX series I2C RTCs > + > +maintainers: > + - Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx> > + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@xxxxxxxxxx> > + > +description: Analog Devices MAX313XX series I2C RTCs. > + > +properties: > + compatible: > + enum: > + - adi,max31328 > + - adi,max31329 > + - adi,max31331 > + - adi,max31334 > + - adi,max31341 > + - adi,max31342 > + - adi,max31343 > + > + reg: > + description: I2C address of the RTC > + items: > + - enum: [0x68, 0x69] > + > + interrupts: > + description: | > + Alarm1 interrupt line of the RTC. Some of the RTCs have two interrupt > + lines and alarm1 interrupt muxing depends on the clockin/clockout > + configuration. > + maxItems: 1 > + > + "#clock-cells": > + description: | > + RTC can be used as a clock source through its clock output pin when > + supplied. This part is correct, but your implementation is not. I don't think you can disable or enable interrupts, based on usage of clock. Either this is clock (gated or not) or interrupt, not both. Best regards, Krzysztof
