Hi Naresh, I love your patch! Yet something to improve: [auto build test ERROR on 8a863eb1b1162653d133856702e13560f3596b85] url: https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/hwmon-pmbus-core-Add-regulator-event-support/20230328-201831 base: 8a863eb1b1162653d133856702e13560f3596b85 patch link: https://lore.kernel.org/r/20230328121712.4057359-2-Naresh.Solanki%409elements.com patch subject: [PATCH 2/3] hwmon: (pmbus/core): Add regulator event support config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20230328/202303282129.T1h4aFZp-lkp@xxxxxxxxx/config) compiler: riscv64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/bc5ab0ded8947e49f5292c04bf381274a0272f3f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Naresh-Solanki/hwmon-pmbus-core-Add-regulator-event-support/20230328-201831 git checkout bc5ab0ded8947e49f5292c04bf381274a0272f3f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/hwmon/pmbus/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303282129.T1h4aFZp-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): drivers/hwmon/pmbus/pmbus_core.c: In function 'pmbus_regulator_get_error_flags': >> drivers/hwmon/pmbus/pmbus_core.c:2938:9: warning: the address of 'event' will always evaluate as 'true' [-Waddress] 2938 | return pmbus_get_flags(data, rdev_get_id(rdev), flags, &event, false); | ^~~~~~ >> drivers/hwmon/pmbus/pmbus_core.c:2938:16: error: too many arguments to function 'pmbus_get_flags' 2938 | return pmbus_get_flags(data, rdev_get_id(rdev), flags, &event, false); | ^~~~~~~~~~~~~~~ drivers/hwmon/pmbus/pmbus_core.c:2886:27: note: declared here 2886 | static int __maybe_unused pmbus_get_flags(struct pmbus_data *data, u8 page, unsigned int *flags, | ^~~~~~~~~~~~~~~ vim +/pmbus_get_flags +2938 drivers/hwmon/pmbus/pmbus_core.c 2930 2931 static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned int *flags) 2932 { 2933 struct device *dev = rdev_get_dev(rdev); 2934 struct i2c_client *client = to_i2c_client(dev->parent); 2935 struct pmbus_data *data = i2c_get_clientdata(client); 2936 int event; 2937 > 2938 return pmbus_get_flags(data, rdev_get_id(rdev), flags, &event, false); 2939 } 2940 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
