On Tue, Mar 21, 2023 at 03:08:45PM +0200, andriy.shevchenko@xxxxxxxxxxxxxxx wrote: > On Tue, Mar 21, 2023 at 10:29:22AM +0000, Winiarska, Iwona wrote: > > On Tue, 2023-03-21 at 10:41 +0100, Paul Menzel wrote: > > > Am 21.03.23 um 10:04 schrieb Iwona Winiarska: > > ... > > > > This is not aligned. Why not only use one space before the equal sign? > > > > Yeah - same alignment problem is present in cpu_hsx and cpu_icx though, so I > > just followed along for skx to not stand out visually. > > So while I agree that alignment is broken here, I think it might be better to > > separate out the potential cleanup from the fix. > > I agree with Iwona. If community wants a cleanup, it can be created in > a separate patch. For the fixes it's better to reduce the unrelated churn. > I don't want a cleanup. The original author chose the alignment, I accepted it because I give submitters some slack when it comes to formatting as long as checkpatch doesn't complain, and I do not want to get into lets-change-alignment wars. Thanks, Guenter
