On Tue, Mar 14, 2023 at 02:31:45AM -0700, Lars-Peter Clausen wrote:
> The adm1266 driver uses I2C bus access in its GPIO chip `set` and `get`
> implementation. This means these functions can sleep and the GPIO chip
> should set the `can_sleep` property to true.
>
> This will ensure that a warning is printed when trying to set or get the
> GPIO value from a context that potentially can't sleep.
>
> Fixes: d98dfad35c38 ("hwmon: (pmbus/adm1266) Add support for GPIOs")
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/pmbus/adm1266.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index ec5f932fc6f0..1ac2b2f4c570 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c
> @@ -301,6 +301,7 @@ static int adm1266_config_gpio(struct adm1266_data *data)
> data->gc.label = name;
> data->gc.parent = &data->client->dev;
> data->gc.owner = THIS_MODULE;
> + data->gc.can_sleep = true;
> data->gc.base = -1;
> data->gc.names = data->gpio_names;
> data->gc.ngpio = ARRAY_SIZE(data->gpio_names);
