Hi phinex, Thank you for the patch! Yet something to improve: [auto build test ERROR on groeck-staging/hwmon-next] [also build test ERROR on linus/master v6.3-rc2 next-20230315] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/phinex/hwmon-drivetemp-support-to-be-a-platform-driver-for-thermal_of/20230315-201903 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next patch link: https://lore.kernel.org/r/20230315121606.GA71707%40threadripper patch subject: [PATCH v1] hwmon: drivetemp: support to be a platform driver for thermal_of config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230315/202303152257.cVusXid9-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1c53b683440a584685795fa8ff831379577081b0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review phinex/hwmon-drivetemp-support-to-be-a-platform-driver-for-thermal_of/20230315-201903 git checkout 1c53b683440a584685795fa8ff831379577081b0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303152257.cVusXid9-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): drivers/hwmon/drivetemp.c: In function 'hdd_read_temp': >> drivers/hwmon/drivetemp.c:551:13: warning: variable 'err' set but not used [-Wunused-but-set-variable] 551 | int err; | ^~~ drivers/hwmon/drivetemp.c: At top level: >> drivers/hwmon/drivetemp.c:575:21: error: variable 'hdd_sensor_ops' has initializer but incomplete type 575 | static const struct thermal_zone_of_device_ops hdd_sensor_ops = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/hwmon/drivetemp.c:576:10: error: 'const struct thermal_zone_of_device_ops' has no member named 'get_temp' 576 | .get_temp = hdd_read_temp, | ^~~~~~~~ >> drivers/hwmon/drivetemp.c:576:21: warning: excess elements in struct initializer 576 | .get_temp = hdd_read_temp, | ^~~~~~~~~~~~~ drivers/hwmon/drivetemp.c:576:21: note: (near initialization for 'hdd_sensor_ops') drivers/hwmon/drivetemp.c: In function 'hdd_hwmon_probe': >> drivers/hwmon/drivetemp.c:668:17: error: implicit declaration of function 'devm_thermal_zone_of_sensor_register'; did you mean 'devm_thermal_of_zone_register'? [-Werror=implicit-function-declaration] 668 | devm_thermal_zone_of_sensor_register( | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | devm_thermal_of_zone_register drivers/hwmon/drivetemp.c: At top level: >> drivers/hwmon/drivetemp.c:575:48: error: storage size of 'hdd_sensor_ops' isn't known 575 | static const struct thermal_zone_of_device_ops hdd_sensor_ops = { | ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/hdd_sensor_ops +575 drivers/hwmon/drivetemp.c 547 548 #if IS_ENABLED(CONFIG_THERMAL_OF) 549 static int hdd_read_temp(void *data, int *temp) 550 { > 551 int err; 552 struct drivetemp_data *st = data; 553 long value, max = 0; 554 555 list_for_each_entry(st, &drivetemp_devlist, list) { 556 mutex_lock(&st->lock); 557 err = st->get_temp(st, hwmon_temp_input, &value); 558 mutex_unlock(&st->lock); 559 560 if (value > max) 561 max = value; 562 } 563 564 /*non-existent sensor or not ready*/ 565 if (max == 0) 566 return -EAGAIN; 567 568 *temp = (int)max; 569 570 dev_dbg(st->dev, "%s, sensor read %d\n", __func__, *temp); 571 572 return 0; 573 } 574 > 575 static const struct thermal_zone_of_device_ops hdd_sensor_ops = { > 576 .get_temp = hdd_read_temp, 577 }; 578 579 static const struct of_device_id hdd_of_match[] = { 580 { 581 .compatible = "drivetemp,hdd-sensors", 582 }, 583 {}, 584 }; 585 MODULE_DEVICE_TABLE(of, hdd_of_match); 586 #endif 587 588 static const struct hwmon_ops drivetemp_ops = { 589 .is_visible = drivetemp_is_visible, 590 .read = drivetemp_read, 591 }; 592 593 static const struct hwmon_chip_info drivetemp_chip_info = { 594 .ops = &drivetemp_ops, 595 .info = drivetemp_info, 596 }; 597 598 /* 599 * The device argument points to sdev->sdev_dev. Its parent is 600 * sdev->sdev_gendev, which we can use to get the scsi_device pointer. 601 */ 602 static int drivetemp_add(struct device *dev, struct class_interface *intf) 603 { 604 struct scsi_device *sdev = to_scsi_device(dev->parent); 605 struct drivetemp_data *st; 606 int err; 607 struct ata_port *ap; 608 609 st = kzalloc(sizeof(*st), GFP_KERNEL); 610 if (!st) 611 return -ENOMEM; 612 613 ap = ata_shost_to_port(sdev->host); 614 615 snprintf(st->drivename, MAX_NAME_LEN, "drivetemp_port%d", ap->port_no); 616 617 st->sdev = sdev; 618 st->dev = dev; 619 mutex_init(&st->lock); 620 621 if (drivetemp_identify(st)) { 622 err = -ENODEV; 623 goto abort; 624 } 625 626 st->hwdev = hwmon_device_register_with_info( 627 dev->parent, st->drivename, st, &drivetemp_chip_info, NULL); 628 629 if (IS_ERR(st->hwdev)) { 630 err = PTR_ERR(st->hwdev); 631 goto abort; 632 } 633 634 list_add(&st->list, &drivetemp_devlist); 635 return 0; 636 637 abort: 638 kfree(st); 639 return err; 640 } 641 642 static void drivetemp_remove(struct device *dev, struct class_interface *intf) 643 { 644 struct drivetemp_data *st, *tmp; 645 646 list_for_each_entry_safe(st, tmp, &drivetemp_devlist, list) { 647 if (st->dev == dev) { 648 list_del(&st->list); 649 hwmon_device_unregister(st->hwdev); 650 kfree(st); 651 break; 652 } 653 } 654 } 655 656 static struct class_interface drivetemp_interface = { 657 .add_dev = drivetemp_add, 658 .remove_dev = drivetemp_remove, 659 }; 660 661 #if IS_ENABLED(CONFIG_THERMAL_OF) 662 static int hdd_hwmon_probe(struct platform_device *pdev) 663 { 664 if (list_empty(&drivetemp_devlist)) 665 return -EPROBE_DEFER; 666 667 if (!tz) > 668 devm_thermal_zone_of_sensor_register( 669 &pdev->dev, 0, &drivetemp_devlist, &hdd_sensor_ops); 670 671 return 0; 672 } 673 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
