Re: [PATCH v1 2/3] hwmon (it87): Add scaling macro for recent ADC voltages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2023-03-12 at 07:49 -0700, Guenter Roeck wrote:
> On 3/11/23 20:31, Frank Crawford wrote:
> > Generalise scaling to include all recent ADC values and match the
> > labels
> > for internal voltage sensor to match.
> > 
> > This includes correction of an existing error for voltage scaling
> > for
> > chips that have 10.9mV ADCs, where scaling was not performed.
> > 
> 
> That is really two patches (one patch per logical change). The bug
> fix
> should be the first patch of the series so it can be backported
> to older kernels.

Okay, ignore this patch set and I'll resubmit them a totally separate
patches.

> 
> In general please only introduce new code like the 11mv scaling
> together
> with code actually using it, or I can not apply it.

The minor problem with holding this off until it is actually used is
that the chipset that uses it also has a lot of other changes, related
to number of fans, etc, and I'm trying to introduce them all as small
increments.  Otherwise I will need to submit a big patch with lots of
unrelated pieces.

> 
> Thanks,
> Guenter

Regards
Frank
> 




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux