On 12/03/2023 19:06, Guenter Roeck wrote: > On Sat, Mar 11, 2023 at 12:16:09PM +0100, Krzysztof Kozlowski wrote: >> The driver can be compile tested with !CONFIG_OF making certain data >> unused: >> >> drivers/hwmon/gpio-fan.c:484:34: error: ‘of_gpio_fan_match’ defined but not used [-Werror=unused-const-variable=] >> > > How do you trigger that ? The driver depends on OF_GPIO which > in turn depends on OF. Arguably that means that of_match_ptr() > doesnot really make sense, but still I don't see how you can > trigger the above error message. I can drop of_match_ptr, it's indeed in many cases not needed. I just build x86_64 allyesconfig minus OF, with W=1. Do you want to me to drop of_match_ptr? Best regards, Krzysztof
