On Fri, Mar 10, 2023 at 08:50:35AM +0100, Marcus Folkesson wrote: > ret is set to 0 which do not indicate an error. > Return -EINVAL instead. > > Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx> Applied. Thanks, Guenter > --- > drivers/hwmon/ina3221.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c > index e06186986444..f3a4c5633b1e 100644 > --- a/drivers/hwmon/ina3221.c > +++ b/drivers/hwmon/ina3221.c > @@ -772,7 +772,7 @@ static int ina3221_probe_child_from_dt(struct device *dev, > return ret; > } else if (val > INA3221_CHANNEL3) { > dev_err(dev, "invalid reg %d of %pOFn\n", val, child); > - return ret; > + return -EINVAL; > } > > input = &ina->inputs[val];