tree: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next head: faaf9f98d1032c901d8e859e3b6883c7e67614b6 commit: 82919ed52f4a2c1b26fa34d6fd5370da06dff816 [35/38] watchdog: bcm47xx: Simplify using devm_watchdog_register_device() config: hexagon-randconfig-r045-20230306 (https://download.01.org/0day-ci/archive/20230307/202303070812.88OvdkNL-lkp@xxxxxxxxx/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=82919ed52f4a2c1b26fa34d6fd5370da06dff816 git remote add groeck-staging https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git git fetch --no-tags groeck-staging watchdog-next git checkout 82919ed52f4a2c1b26fa34d6fd5370da06dff816 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/watchdog/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303070812.88OvdkNL-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/watchdog/bcm47xx_wdt.c:205:47: error: too few arguments to function call, expected 2, have 1 ret = devm_watchdog_register_device(&wdt->wdd); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ include/linux/watchdog.h:226:5: note: 'devm_watchdog_register_device' declared here int devm_watchdog_register_device(struct device *dev, struct watchdog_device *); ^ 1 error generated. vim +205 drivers/watchdog/bcm47xx_wdt.c 176 177 static int bcm47xx_wdt_probe(struct platform_device *pdev) 178 { 179 int ret; 180 bool soft; 181 struct bcm47xx_wdt *wdt = dev_get_platdata(&pdev->dev); 182 183 if (!wdt) 184 return -ENXIO; 185 186 soft = wdt->max_timer_ms < WDT_SOFTTIMER_THRESHOLD * 1000; 187 188 if (soft) { 189 wdt->wdd.ops = &bcm47xx_wdt_soft_ops; 190 timer_setup(&wdt->soft_timer, bcm47xx_wdt_soft_timer_tick, 0); 191 } else { 192 wdt->wdd.ops = &bcm47xx_wdt_hard_ops; 193 } 194 195 wdt->wdd.info = &bcm47xx_wdt_info; 196 wdt->wdd.timeout = WDT_DEFAULT_TIME; 197 wdt->wdd.parent = &pdev->dev; 198 ret = wdt->wdd.ops->set_timeout(&wdt->wdd, timeout); 199 if (ret) 200 goto err_timer; 201 watchdog_set_nowayout(&wdt->wdd, nowayout); 202 watchdog_set_restart_priority(&wdt->wdd, 64); 203 watchdog_stop_on_reboot(&wdt->wdd); 204 > 205 ret = devm_watchdog_register_device(&wdt->wdd); 206 if (ret) 207 goto err_timer; 208 209 dev_info(&pdev->dev, "BCM47xx Watchdog Timer enabled (%d seconds%s%s)\n", 210 timeout, nowayout ? ", nowayout" : "", 211 soft ? ", Software Timer" : ""); 212 return 0; 213 214 err_timer: 215 if (soft) 216 del_timer_sync(&wdt->soft_timer); 217 218 return ret; 219 } 220 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
