On 2023-02-11 18:41:52 GMT+01:00, Guenter Roeck wrote: > > Adding the capability without actually supporting it raises the expectation > that it works from those who don't know better. Please only provide the > capability to set the mode where it is actually supported. > > Otherwise one could argue along the line of 'hey, let's just "enable" > all attributes no matter if supported or not', which would lead to a > lot of confusion. I really hope that isn't done with other attributes > in this driver. (snip) > > ... and it isn't even mentioned here that the mode only works on > Aquacomputer Aquaero, and only on the 4th port for Aquaero 5. > > Really, please don't do that, and I sincerely hope that the driver > doesn't hide (i.e., claim to support when it isn't really supported) > other similar limitations. > > Guenter It doesn't, features are exposed if the device supports them. I'm part to blame for this one, I didn't create an issue at the upstream Github repo to track this. We'll try to find a way to differentiate between aquaero 5 and 6 - the aquaero 6 is basically an expanded version of the 5 with more powerful hardware, firmware seems to be relatively similar. Aleksa
