On Mon, Feb 06, 2023 at 03:13:25PM +0100, Hans de Goede wrote: > Hi Armin, > > On 2/5/23 21:54, Armin Wolf wrote: > > Thanks to bugreport 216655 on bugzilla triggered by the > > dell-smm-hwmon driver, the contents of the sensor buffers > > could be almost completely decoded. > > Add an hwmon interface for exposing the fan and thermal > > sensor values. Since the WMI interface can be quite slow > > on some machines, the sensor buffers are cached for 1 second > > to lessen the performance impact. > > The debugfs interface remains in place to aid in reverse-engineering > > of unknown sensor types and the thermal buffer. > > > > Tested-by: Antonín Skala <skala.antonin@xxxxxxxxx> > > Tested-by: Gustavo Walbon <gustavowalbon@xxxxxxxxx> > > Signed-off-by: Armin Wolf <W_Armin@xxxxxx> > > This looks nice and clean to me, thank you: > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > I'm going to wait a bit with merging this to see if Guenter > has any remarks. If there are no remarks by next Monday then > I'll merge this for the 6.3 merge window. > I don't have any further remarks. I won't send an Ack, though. I noticed that the empty lines before return statements distract me sufficiently enough that I am not sure about the actual code. Guenter
