Re: [PATCH] hwmon: (pmbus/core): Generalize pmbus status flag map

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 1/18/23 06:36, Naresh Solanki wrote:
Hi Guenter,

On 18-01-2023 07:13 pm, Guenter Roeck wrote:
On 1/18/23 03:15, Naresh Solanki wrote:
Move the PMBus status flag map (pmbus_regulator_status_flag_map)
outside of the regulator #if block and update the associated
variable/struct name to reflect a generic PMBus status. Also retain
the regulator error flag for use in determining regulator specific error.

This will make the PMBus status flag map more versatile and easier to
incorporate into different contexts and functions.

Signed-off-by: Naresh Solanki <Naresh.Solanki@xxxxxxxxxxxxx>

Sorry, I don't see the point of moving a structure including
regulator error codes outside regulator code.
I'm working on adding pmbus irq handler.
Since irq handler is regulator independent, this change is needed.

Please submit the necessary patches together. I can not accept patches
introducing structural changes like this without use case.


[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux