Hi Guenter et al.,
On Thu, Dec 22, 2022 at 3:36 PM kernel test robot <lkp@xxxxxxxxx> wrote:
[...]
> 475 static bool jc42_readable_reg(struct device *dev, unsigned int reg)
> 476 {
> > 477 return (reg >= JC42_REG_CAP && reg <= JC42_REG_DEVICEID) ||
> 478 reg == JC42_REG_SMBUS;
The bot is right: we can omit "reg >= JC42_REG_CAP" as it's already
covered by the fact that:
- the reg variable is unsigned, which means the lower limit is zero
- reg <= JC42_REG_DEVICEID covers the upper limit
Before I send a patch I'd like to hear if removal of "reg >=
JC42_REG_CAP" makes sense to other people.
Best regards,
Martin
