On 26/11/2022 15.18, Andy Shevchenko wrote: > First of all, the struct rtc_device pointer is kept in the managed > resources, no need to keep it outside (no users in the driver). > > Second, replace private struct isl12022 with a regmap. Nice simplification. Acked-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>