On 26/11/2022 18:17, Saravanan Sekar wrote:
> The MPQ7932 is a power management IC designed to operate from 5V buses to
> power a variety of ADAS SOCs. Six integrated buck converters power a
> variety of target rails configurable over PMBus interface.
>
> Signed-off-by: Saravanan Sekar <saravanan@xxxxxxxxxxx>
> ---
> drivers/hwmon/pmbus/Kconfig | 9 ++
> drivers/hwmon/pmbus/Makefile | 1 +
> drivers/hwmon/pmbus/mpq7932.c | 150 ++++++++++++++++++++++++++++++++++
> 3 files changed, 160 insertions(+)
> create mode 100644 drivers/hwmon/pmbus/mpq7932.c
>
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index 89668af67206..5e938768bd77 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -317,6 +317,15 @@ config SENSORS_MP5023
> This driver can also be built as a module. If so, the module will
> be called mp5023.
>
> +config SENSORS_MPQ7932_REGULATOR
> + tristate "MPS MPQ7932 buck regulator"
It's a regulator, not hwmon.
> + help
> + If you say yes here you get six integrated buck converter
> + regulator support for power management IC MPS MPQ7932.
> +
> + This driver can also be built as a module. If so, the module will
> + be called mpq7932.
> +
> config SENSORS_PIM4328
> tristate "Flex PIM4328 and compatibles"
> help
> diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
> index 0002dbe22d52..28a534629cc3 100644
> --- a/drivers/hwmon/pmbus/Makefile
> +++ b/drivers/hwmon/pmbus/Makefile
> @@ -34,6 +34,7 @@ obj-$(CONFIG_SENSORS_MAX8688) += max8688.o
> obj-$(CONFIG_SENSORS_MP2888) += mp2888.o
> obj-$(CONFIG_SENSORS_MP2975) += mp2975.o
> obj-$(CONFIG_SENSORS_MP5023) += mp5023.o
> +obj-$(CONFIG_SENSORS_MPQ7932_REGULATOR) += mpq7932.o
> obj-$(CONFIG_SENSORS_PLI1209BC) += pli1209bc.o
> obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o
> obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o
> diff --git a/drivers/hwmon/pmbus/mpq7932.c b/drivers/hwmon/pmbus/mpq7932.c
> new file mode 100644
> index 000000000000..23d3ccdaed1e
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/mpq7932.c
> @@ -0,0 +1,150 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// mpq7932.c - regulator driver for mps mpq7932
> +//
> +// Copyright 2022 Monolithic Power Systems, Inc
> +//
> +// Author: Saravanan Sekar <saravanan@xxxxxxxxxxx>
> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/init.h>
> +#include <linux/err.h>
> +#include <linux/of_device.h>
> +#include <linux/pmbus.h>
> +#include <linux/i2c.h>
> +#include "pmbus.h"
> +
> +#define MPQ7932_BUCK_UV_MIN 206250
> +#define MPQ7932_UV_STEP 6250
> +#define MPQ7932_N_VOLTAGES 0xFF
> +#define MPQ7932_NUM_PAGES 6
> +
> +#define MPQ7932_TON_DELAY 0x60
> +#define MPQ7932_VOUT_STARTUP_SLEW 0xA3
> +#define MPQ7932_VOUT_SHUTDOWN_SLEW 0xA5
> +#define MPQ7932_VOUT_SLEW_MASK GENMASK(1, 0)
> +#define MPQ7932_TON_DELAY_MASK GENMASK(4, 0)
> +
> +#define MPQ7932BUCK(_id) \
> + [_id] = { \
> + .id = _id, \
> + .name = ("buck" # _id), \
> + .of_match = of_match_ptr("buck" # _id), \
> + .regulators_node = "regulators", \
> + .ops = &pmbus_regulator_ops, \
> + .type = REGULATOR_VOLTAGE, \
> + .min_uV = MPQ7932_BUCK_UV_MIN, \
> + .uV_step = MPQ7932_UV_STEP, \
> + .n_voltages = MPQ7932_N_VOLTAGES, \
> + }
> +
> +struct mpq7932_data {
> + struct pmbus_driver_info info;
> + struct pmbus_platform_data pdata;
> +};
> +
> +static struct regulator_desc mpq7932_regulators_desc[] = {
> + MPQ7932BUCK(0),
> + MPQ7932BUCK(1),
> + MPQ7932BUCK(2),
> + MPQ7932BUCK(3),
> + MPQ7932BUCK(4),
> + MPQ7932BUCK(5),
> +};
> +
> +static int mpq7932_write_word_data(struct i2c_client *client, int page, int reg,
> + u16 word)
> +{
> +
> + switch (reg) {
> + case PMBUS_VOUT_COMMAND:
> + return pmbus_write_byte_data(client, page, reg, (u8)word);
> +
> + default:
> + return -ENODATA;
> + }
> +}
> +
> +static int mpq7932_read_word_data(struct i2c_client *client, int page,
> + int phase, int reg)
> +{
> +
> + switch (reg) {
> + case PMBUS_MFR_VOUT_MIN:
> + return 0;
> +
> + case PMBUS_MFR_VOUT_MAX:
> + return MPQ7932_N_VOLTAGES;
> +
> + case PMBUS_READ_VOUT:
> + return pmbus_read_byte_data(client, page, PMBUS_VOUT_COMMAND);
> +
> + default:
> + return -ENODATA;
> + }
> +}
> +
> +static int mpq7932_probe(struct i2c_client *client)
> +{
> + struct mpq7932_data *data;
> + struct pmbus_driver_info *info;
> + struct device *dev = &client->dev;
> + int i;
> +
> + if (!i2c_check_functionality(client->adapter,
> + I2C_FUNC_SMBUS_READ_WORD_DATA))
> + return -ENODEV;
> +
> + data = devm_kzalloc(&client->dev, sizeof(struct mpq7932_data),
> + GFP_KERNEL);
> + if (!data)
> + return -ENOMEM;
> +
> + info = &data->info;
> + info->pages = MPQ7932_NUM_PAGES;
> + info->num_regulators = ARRAY_SIZE(mpq7932_regulators_desc);
> + info->reg_desc = mpq7932_regulators_desc;
> + info->format[PSC_VOLTAGE_OUT] = direct;
> + info->m[PSC_VOLTAGE_OUT] = 160;
> + info->b[PSC_VOLTAGE_OUT] = -33;
> + for (i = 0; i < info->pages; i++) {
> + info->func[i] = PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT
> + | PMBUS_HAVE_STATUS_TEMP;
> + }
> +
> + info->read_word_data = mpq7932_read_word_data;
> + info->write_word_data = mpq7932_write_word_data;
> +
> + data->pdata.flags = PMBUS_NO_CAPABILITY;
> + dev->platform_data = &data->pdata;
> +
> + return pmbus_do_probe(client, info);
> +}
> +
> +static const struct of_device_id mpq7932_of_match[] = {
> + { .compatible = "mps,mpq7932"},
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, mpq7932_of_match);
> +
> +static const struct i2c_device_id mpq7932_id[] = {
> + { "mpq7932", },
> + { },
> +};
> +MODULE_DEVICE_TABLE(i2c, mpq7932_id);
> +
> +static struct i2c_driver mpq7932_regulator_driver = {
> + .driver = {
> + .name = "mpq7932",
> + .of_match_table = of_match_ptr(mpq7932_of_match),
Missing maybe_unused, so drop of_match_ptr.
Best regards,
Krzysztof
