On 26/11/2022 18:17, Saravanan Sekar wrote: > Add bindings for mps,mpq7932 power-management IC > > Signed-off-by: Saravanan Sekar <saravanan@xxxxxxxxxxx> > --- > .../bindings/hwmon/pmbus/mps,mpq7932.yaml | 69 +++++++++++++++++++ Use subject prefixes matching the subsystem (git log --oneline -- ...). > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq7932.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq7932.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq7932.yaml > new file mode 100644 > index 000000000000..6ec072c287a3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq7932.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mps,mpq7932.yaml# Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Monolithic Power System MPQ7932 PMIC > + > +maintainers: > + - Saravanan Sekar <saravanan@xxxxxxxxxxx> > + > +properties: > + $nodename: > + pattern: "pmic@[0-9a-f]{1,2}" Why requiring nodename? Device schemas usually don't do that. > + compatible: > + enum: > + - mps,mpq7932 > + > + reg: > + maxItems: 1 > + > + regulators: > + type: object > + $ref: regulator.yaml# regulators node is a regulator with one more regulator? Drop. > + > + description: | > + list of regulators provided by this controller, must be named > + after their hardware counterparts BUCK[1-6] > + > + "^buck[1-6]$": > + type: object > + $ref: regulator.yaml# > + Drop blank line. > + unevaluatedProperties: false > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@69 { > + compatible = "mps,mpq7932"; Messed indentation. Use same for entire example, e.g. 4-spaces. > + reg = <0x69>; > + > + regulators { > + Drop blank line. > + buck1 { > + regulator-name = "buck1"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <3587500>; > + regulator-min-microamp = <460000>; > + regulator-max-microamp = <7600000>; > + regulator-boot-on; > + }; > + Why blank line here? Drop it. > + }; > + }; > + }; > +... Best regards, Krzysztof
