On 11/2/22 19:27, wangkailong@xxxxxxx wrote: > Fix the following coccicheck warning: > > drivers/hwmon/amc6821.c:215: WARNING: Unsigned expression compared > with zero: reg > 0 > drivers/hwmon/amc6821.c:228: WARNING: Unsigned expression compared > with zero: reg > 0 > > Signed-off-by: KaiLong Wang <wangkailong@xxxxxxx> Hm. IDGI. What's wrong with comparing an unsigned value to > 0? I mean, it could be == 0 or > 0. Please explain. > --- > drivers/hwmon/amc6821.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c > index 3bfd12ff4b3c..1f5382f8d52b 100644 > --- a/drivers/hwmon/amc6821.c > +++ b/drivers/hwmon/amc6821.c > @@ -166,7 +166,7 @@ static struct amc6821_data *amc6821_update_device(struct device *dev) > struct amc6821_data *data = dev_get_drvdata(dev); > struct i2c_client *client = data->client; > int timeout = HZ; > - u8 reg; > + int reg; > int i; > > mutex_lock(&data->update_lock); -- ~Randy
