On 10/29/22 03:30, Frank Crawford wrote:
Changes in this patch set: * Define the DMI matching table for board specific settings during the chip initialisation and move the only current board specific setting to this new table. * Export the table for use by udev. v2: updates following comments: * Converted to use callback function. * Moved call to callback funtion to sio_data into it87_find in line with other settings for sio_data. This requires dmi_data also passed to access additional data.
That is really not what I meant when I asked to use a callback function. As written, the code might as well call that function directly from the init code, and there would be no reason to have a callback function pointer. A callback function would only make sense to me if it is added to struct dmi_system_id, and called via dmi_check_system(). See other callers of dmi_check_system() for examples. Thanks, Guenter
