Re: [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

["Dixit, Ashutosh" <ashutosh.dixit@xxxxxxxxx>]

On Wed, 21 Sep 2022 05:02:48 -0700, Gupta, Anshuman wrote:
>
> > diff --git a/drivers/gpu/drm/i915/intel_mchbar_regs.h b/drivers/gpu/drm/i915/intel_mchbar_regs.h
> > index b74df11977c6..1014d0b7cc16 100644
> > --- a/drivers/gpu/drm/i915/intel_mchbar_regs.h
> > +++ b/drivers/gpu/drm/i915/intel_mchbar_regs.h
> > @@ -191,7 +191,9 @@
> >     #define PCU_PACKAGE_POWER_SKU_UNIT
> > _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5938)
> >   #define   PKG_PWR_UNIT				REG_GENMASK(3, 0)
> > +#define   PKG_ENERGY_UNIT                      REG_GENMASK(12, 8)
> Please use tab here instead of space to line up with above macros.

Fixed in v9.

> With that,
> Reviewed-by: Anshuman Gupta <anshuman.gupta@xxxxxxxxx>

Thanks.