On Friday 30 September 2022 14:46:18 Pali Rohár wrote:
> + CC hwmon ML
>
> On Friday 30 September 2022 14:39:01 Pali Rohár wrote:
> > Channel 0 of SA56004ED chip refers to internal SA56004ED chip sensor (chip
> > itself is located on the board) and channel 1 of SA56004ED chip refers to
> > external sensor which is connected to temperature diode of the P2020 CPU.
> >
> > Fixes: 54c15ec3b738 ("powerpc: dts: Add DTS file for CZ.NIC Turris 1.x routers")
> > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> > ---
> > With this change userspace 'sensors' applications prints labels:
> >
> > $ sensors
> > sa56004-i2c-0-4c
> > Adapter: MPC adapter (i2c@3000)
> > board: +34.2°C (low = +0.0°C, high = +70.0°C)
> > (crit = +85.0°C, hyst = +75.0°C)
> > cpu: +58.9°C (low = +0.0°C, high = +70.0°C)
> > (crit = +85.0°C, hyst = +75.0°C)
> >
> > And without this change it prints just generic tempX names:
> >
> > $ sensors
> > sa56004-i2c-0-4c
> > Adapter: MPC adapter (i2c@3000)
> > temp1: +43.0°C (low = +0.0°C, high = +70.0°C)
> > (crit = +85.0°C, hyst = +75.0°C)
> > temp2: +63.4°C (low = +0.0°C, high = +70.0°C)
> > (crit = +85.0°C, hyst = +75.0°C)
> > ---
> > arch/powerpc/boot/dts/turris1x.dts | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/powerpc/boot/dts/turris1x.dts b/arch/powerpc/boot/dts/turris1x.dts
> > index 4033c554b06a..5b5278c32e43 100644
> > --- a/arch/powerpc/boot/dts/turris1x.dts
> > +++ b/arch/powerpc/boot/dts/turris1x.dts
> > @@ -69,6 +69,20 @@
> > interrupt-parent = <&gpio>;
> > interrupts = <12 IRQ_TYPE_LEVEL_LOW>, /* GPIO12 - ALERT pin */
> > <13 IRQ_TYPE_LEVEL_LOW>; /* GPIO13 - CRIT pin */
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + /* Local temperature sensor (SA56004ED internal) */
> > + channel@0 {
> > + reg = <0>;
> > + label = "board";
> > + };
> > +
> > + /* Remote temperature sensor (D+/D- connected to P2020 CPU Temperature Diode) */
> > + channel@1 {
> > + reg = <1>;
> > + label = "cpu";
> > + };
>
> I'm not sure if you want UPPERCASE, lowercase, PascalCase, kebab-case
> or snake_case format of labels. Or if you want also "temp" or
> "temperature" keyword in the label. So please adjust label to the
> preferred one, if proposed format is not the correct.
Ok, if nobody complains then please take this patch as is.
> > };
> >
> > /* DDR3 SPD/EEPROM */
> > --
> > 2.20.1
> >
