On 10/4/22 09:24, Ahmad Khalifa wrote:
On 03/10/2022 21:50, Guenter Roeck wrote:
On 10/3/22 13:30, Ahmad Khalifa wrote:
On 03/10/2022 19:10, Guenter Roeck wrote:
On Sun, Oct 02, 2022 at 06:43:00PM +0100, Ahmad Khalifa wrote:
They are unrelated, period. You only consider systems where a resource
conflict exists. Also, you could (try to) use acpi_enforce_resources=lax
instead.
Everything else is just a coincidence that applies to _your_ system.
[...]
That isn't the point here. The problem is not with the patches, it is with
the rationale for the patches.
Fair point.
The force_id change is warranted on its own, even without the ignore_resource_conflict because:
- Chipsets will reply with all 1s if no LPC peripheral is connected
Useful for lots of systems with a single device
- IT87 will reply with all 1s if you don't enter config space correctly
Useful for those who override with a known id, but the device is
quite different
- The driver supports 2 sio devices, but the use of force_id is
mostly a single-device use case. It doesn't support forcing two
different devices, so it's safe to assume a non-existent device
is not expected for those users.
My systems run mostly tainted Kernels and I can even grab the temps with a shell script, so I'm not worried about my systems, but they're the
only ones I can test with :)
The kernel parameter is an option that works, but it's a bit more
technical for general users to update their bootloader and change
modprobe config at the same time. This whole patch is about making
the it87 more usable with less compile/install work.
That is not an argument. If acpi_enable_resources=lax would work,
there would be no reason for the ignore_resource_conflict
module parameter.
I can prep v3 with both changes if that's still a good approach.
Here is the original rationale for introducing ignore_resource_conflict.
It appears that some BIOSes reserve ACPI resources without using them,
and acpi_enable_resources=lax seems to result in failures to load
certain drivers.
Introduce a 'ignore_resource_conflict' module parameter as alternate
means to ignore ACPI resource conflicts.
The rationale for the force_id change was:
If the reported chip ID is 0xffff, there is no chip, and forcing the chip
type does not add value.
That is it. No other rationale is needed, and the patch introducing
ignore_resource_conflict needs to explain (like the above) why
acpi_enable_resources=lax is insufficient.
Guenter
