Hi,
On 9/20/22 10:44, Yang Yingliang wrote:
> turn_on_panel_on_resume is only used in toshiba_acpi.c now, change it
> to static.
>
> Fixes: 3cb1f40dfdc3 ("drivers/platform: toshiba_acpi: Call HCI_PANEL_POWER_ON on resume on some models")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/toshiba_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
> index 43cc25351aea..01f92726fef7 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -53,7 +53,7 @@ MODULE_AUTHOR("John Belmonte");
> MODULE_DESCRIPTION("Toshiba Laptop ACPI Extras Driver");
> MODULE_LICENSE("GPL");
>
> -int turn_on_panel_on_resume = -1;
> +static int turn_on_panel_on_resume = -1;
> module_param(turn_on_panel_on_resume, int, 0644);
> MODULE_PARM_DESC(turn_on_panel_on_resume,
> "Call HCI_PANEL_POWER_ON on resume (-1 = auto, 0 = no, 1 = yes");
