On Wed, Sep 14, 2022 at 01:43:27PM +0200, Aleksa Savic wrote:
> The offsets for setting speeds of fans connected to Quadro are off by one.
> Set them to their correct values.
>
> The offsets as shown point to registers for setting the fan control mode,
> which will be explored in future patches, but slipped in here. When
> setting fan speeds, the resulting values were overlapping, which made the
> fans still run in my initial testing.
>
> Fixes: cdbe34da01e3 ("hwmon: (aquacomputer_d5next) Add support for Aquacomputer Quadro fan controller")
> Signed-off-by: Aleksa Savic <savicaleksa83@xxxxxxxxx>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/aquacomputer_d5next.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/aquacomputer_d5next.c b/drivers/hwmon/aquacomputer_d5next.c
> index 3ea25edfc7a5..c51a2678f0eb 100644
> --- a/drivers/hwmon/aquacomputer_d5next.c
> +++ b/drivers/hwmon/aquacomputer_d5next.c
> @@ -120,7 +120,7 @@ static u16 octo_ctrl_fan_offsets[] = { 0x5B, 0xB0, 0x105, 0x15A, 0x1AF, 0x204, 0
> static u8 quadro_sensor_fan_offsets[] = { 0x70, 0x7D, 0x8A, 0x97 };
>
> /* Fan speed registers in Quadro control report (from 0-100%) */
> -static u16 quadro_ctrl_fan_offsets[] = { 0x36, 0x8b, 0xe0, 0x135 };
> +static u16 quadro_ctrl_fan_offsets[] = { 0x37, 0x8c, 0xe1, 0x136 };
>
> /* Register offsets for the High Flow Next */
> #define HIGHFLOWNEXT_NUM_SENSORS 2
