At 2022-09-15 20:25:36, "Guenter Roeck" <linux@xxxxxxxxxxxx> wrote:
>On Thu, Sep 15, 2022 at 05:06:27PM +0800, Liang He wrote:
>> In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
>> the of_find_compatible_node() which will automatically call
>> of_node_put() for the 'from' argument.
>>
>> Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
>> Co-developed-by: Mengda Chen <chenmengda2009@xxxxxxx>
>> Signed-off-by: Mengda Chen <chenmengda2009@xxxxxxx>
>> Signed-off-by: Liang He <windhl@xxxxxxx>
>
>Sigh. The first signer is supposed to be the author.
>
>Guenter
Hi, Guenter
I search the commit history and found several recent but different commits
This one is same with mine: Co-developed-by: A & SOB First & SOB Author, following the kernel doc
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.0-rc5&id=7e97cfed9929eaabc41829c395eb0d1350fccb9d
But, this one is consistent with your advise: SOB Author & Co-developed-by: A & SOB A
(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.0-rc5&id=ef69aa3a986ef94f01ce8b5b619f550db54432fe
So please tell me what I should follow?
Thanks very much.
Liang
>
>> ---
>>
>> v2: use proper tags advised by Guenter and based on Kernel Doc
>>
>> drivers/hwmon/gsc-hwmon.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hwmon/gsc-hwmon.c b/drivers/hwmon/gsc-hwmon.c
>> index d64be48f1ef6..b60ec95b5edb 100644
>> --- a/drivers/hwmon/gsc-hwmon.c
>> +++ b/drivers/hwmon/gsc-hwmon.c
>> @@ -267,6 +267,7 @@ gsc_hwmon_get_devtree_pdata(struct device *dev)
>> pdata->nchannels = nchannels;
>>
>> /* fan controller base address */
>> + of_node_get(dev->parent->of_node);
>> fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan");
>> if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) {
>> of_node_put(fan);
>> --
>> 2.25.1
>>
