On Thu, Sep 15, 2022 at 03:10:54PM +0800, Liang He wrote:
>
>
>
> At 2022-09-15 14:59:10, "Guenter Roeck" <linux@xxxxxxxxxxxx> wrote:
> >On Thu, Sep 15, 2022 at 10:02:45AM +0800, Liang He wrote:
> >> In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
> >> the of_find_compatible_node() which will automatically call
> >> of_node_put() for the 'from' argument.
> >>
> >> Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
> >> Signed-off-by: Liang He <windhl@xxxxxxx>
> >> Signed-off-by: Mengda Chen <chenmengda2009@xxxxxxx>
> >
> >That second Signed-off-by: doesn't make sense in this context since
> >the patch is from and was sent by the first signer.
> >
>
> >Guenter
>
>
> Hi, Guenter
>
> I wonder if it is OK if mengda send a Signed-off-by for this
> or I shoud resend another new version (V2) in which I only attach my SOB
> and then mengda sends his SOB.
>
That is not how it works. SOB means a patch passed through a person
(for example a sub-maintainer). One does not send it as response to
a patch. A tag sent as response should be Reviewed-by: or Acked-by:.
Thanks,
Guenter
> Thanks very much!
>
> Liang
>
>
>
> >> ---
> >> drivers/hwmon/gsc-hwmon.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/hwmon/gsc-hwmon.c b/drivers/hwmon/gsc-hwmon.c
> >> index d64be48f1ef6..b60ec95b5edb 100644
> >> --- a/drivers/hwmon/gsc-hwmon.c
> >> +++ b/drivers/hwmon/gsc-hwmon.c
> >> @@ -267,6 +267,7 @@ gsc_hwmon_get_devtree_pdata(struct device *dev)
> >> pdata->nchannels = nchannels;
> >>
> >> /* fan controller base address */
> >> + of_node_get(dev->parent->of_node);
> >> fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan");
> >> if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) {
> >> of_node_put(fan);
> >> --
> >> 2.25.1
> >>
