On 09/09/2022 09:16, Ibrahim Tilki wrote: > Adding bindings for Analog Devices MAX31760 Fan-Speed Controller > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx> > --- > .../bindings/hwmon/adi,max31760.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > new file mode 100644 > index 000000000..003ec1317 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/adi,max31760.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX31760 Fan-Speed Controller > + > +maintainers: > + - Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx> > + > +description: | > + Analog Devices MAX31760 Fan-Speed Controller > + https://datasheets.maximintegrated.com/en/ds/MAX31760.pdf > + > +properties: > + compatible: > + enum: > + - adi,max31760 > + > + reg: > + description: | No need for | > + I2C address of slave device. maxItems: 1 > + items: > + minimum: 0x50 > + maximum: 0x57 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { Just i2c. > + #address-cells = <1>; > + #size-cells = <0>; > + > + max31760@50 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + reg = <0x50>; > + compatible = "adi,max31760"; Messed up indentation. 4 spaces for DTS example. > + }; > + }; Best regards, Krzysztof