On Thu, Sep 08, 2022 at 03:24:48PM +0000, Eliav Farber wrote: > This change adds debugfs to read and write temperature sensor coefficients > - g, h, j and cal5. > > The coefficients can vary between product and product, so it can be very > useful to be able to modify them on the fly during the calibration > process. > > e.g.: > > cat /sys/kernel/debug/940f23d0000.pvt/ts_coeff_cal5 > 4096 > > echo 83000 > sys/kernel/debug/940f23d0000.pvt/ts_coeff_g ... > - Return j coefficient to use debugfs_create_file() instead of > debugfs_create_u32() because j is signed. You can use DEFINE_DEBUGFS_ATTRIBUTE(ts_coeff_j, ts_coeff_j_get, ts_coeff_j_set, "%lld\n"); which still makes code compact. -- With Best Regards, Andy Shevchenko
