On 9/7/22 07:42, Andy Shevchenko wrote:
On Wed, Sep 07, 2022 at 09:50:00AM +0300, Farber, Eliav wrote:
On 9/6/2022 7:52 PM, Guenter Roeck wrote:
On Tue, Sep 06, 2022 at 08:33:36AM +0000, Eliav Farber wrote:
Fix: "ERROR: space required before the open parenthesis '('"
Fixes: 9d823351a337 ("hwmon: Add hardware monitoring driver for
Moortec MR75203 PVT controller")
Coding style "fixes" do not fix the code. I consider using the Fixes: tag
for those to close to an abuse of that tag (and it would be great if that
was spelled out somewhere). As it is, I can not with good conscience
apply
this patch to the mainline kernel (especially not for -rc5), meaning the
entire series will have to wait for the next release window unless there
are no conflicts.
Because as you mentioned it is not a functional fix in the code I’ll
remove the Fixes tag in v5.
I checked older kernel versions and patch applies without conflicts.
That’s also why I moved it to be first in the series, so it will be
before any of my other changes that night cause merge problems for
other branches.
If it's not a fix, it should go _after_ real fixes.
And by nature this kind of patch is usually at the end of the series.
I don't care where it is, really, as long as it is after the real fixes.
And obviously I would not want to see a patch fixing something introduced
in a previous patch of the same series.
Thanks,
Guenter
