On Thu, Sep 01, 2022 at 06:24:51PM +0300, Farber, Eliav wrote: > On 9/1/2022 5:44 PM, Guenter Roeck wrote: > > On Thu, Sep 01, 2022 at 11:39:58AM +0300, Farber, Eliav wrote: ... > > There should be some error handling to catch this case (ie if the number > > of entries does not match the expected count), or if a value in the array > > is larger or equal to vm_num. Today the latter is silently handled as end > > of entries (similar to 0xff), but that should result in an error. > > This would avoid situations like > > intel,vm-map = [01 02 03 04 05]; > > ie where the person writing the devicetree file accidentally entered > > index values starting with 1 instead of 0. A mismatch between vm_num > > and the number of entries in the array is silently handled as if there > > was no property at all, which is at the very least misleading and > > most definitely unexpected and should also result in an error. > > I assume it is possible to tell according to the return value, if property > doesn’t exist at all, or if it does exists and size of array in > device-tree is smaller than vm_num. > In [PATCH v3 17/19] Andy wrote that “code shouldn't be a YAML validator. > Drop this and make sure you have correct DT schema” so I’m a bit confused > if code should validate “intel,bm-map” or if it is the user responsibility. > As this property was not added by me, I prefer not to fix it as part of > this series of patches. I'm just a messenger of Rob's words. If I'm mistaken I would like Rob to correct me. -- With Best Regards, Andy Shevchenko
