Re: [PATCH v2 16/16] hwmon: (mr75203) add debugfs to read and write temperature coefficients

To: Guenter Roeck <linux@xxxxxxxxxxxx>
Subject: Re: [PATCH v2 16/16] hwmon: (mr75203) add debugfs to read and write temperature coefficients
From: "Farber, Eliav" <farbere@xxxxxxxxxx>
Date: Mon, 29 Aug 2022 21:41:58 +0300
Cc: <jdelvare@xxxxxxxx>, <robh+dt@xxxxxxxxxx>, <mark.rutland@xxxxxxx>, <linux-hwmon@xxxxxxxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <talel@xxxxxxxxxx>, <hhhawa@xxxxxxxxxx>, <jonnyc@xxxxxxxxxx>, <hanochu@xxxxxxxxxx>, <ronenk@xxxxxxxxxx>, <itamark@xxxxxxxxxx>, <shellykz@xxxxxxxxxx>, <shorer@xxxxxxxxxx>, <amitlavi@xxxxxxxxxx>, <almogbs@xxxxxxxxxx>, <dwmw@xxxxxxxxxxxx>, <rtanwar@xxxxxxxxxxxxx>, "Farber, Eliav" <farbere@xxxxxxxxxx>
In-reply-to: <20220822162805.GD4098765@roeck-us.net>
References: <20220817054321.6519-1-farbere@amazon.com> <20220817054321.6519-17-farbere@amazon.com> <20220818231106.GA3505191@roeck-us.net> <75165e58-8601-1fe5-7bdb-98761a73701f@amazon.com> <20220822162805.GD4098765@roeck-us.net>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0

On 8/22/2022 7:28 PM, Guenter Roeck wrote:

There needs to be an overflow protection. I am quite sure that 0xffffffff
would result in overflows and thus in quite random reported values.

Added overflow protection.
Will be part of v3.

--
Thanks, Eliav

References:
- [PATCH v2 00/16] Variety of fixes and new features for mr75203 driver
  - From: Eliav Farber
- [PATCH v2 16/16] hwmon: (mr75203) add debugfs to read and write temperature coefficients
  - From: Eliav Farber
- Re: [PATCH v2 16/16] hwmon: (mr75203) add debugfs to read and write temperature coefficients
  - From: Guenter Roeck
- Re: [PATCH v2 16/16] hwmon: (mr75203) add debugfs to read and write temperature coefficients
  - From: Farber, Eliav
- Re: [PATCH v2 16/16] hwmon: (mr75203) add debugfs to read and write temperature coefficients
  - From: Guenter Roeck