On Mon, Aug 22, 2022 at 07:40:53PM +0200, Armin Wolf wrote:
> When dell-smm-hwmon is loaded on a machine with a buggy BIOS
> with the option "force" being enabled, it wrongly prints
> that the buggy features where disabled. This may cause
> users to wrongly assume that the driver still protects them
> from these BIOS bugs even with "force" being enabled.
>
> Replace the messages with two messages each which are depending
> on the value of the "force" parameter. The messages which are
> being printed when "force" is not set use dev_notice() instead
> of dev_warn() since they only serve as a notice.
>
> Tested on a Dell Inspiron 3505.
>
> Signed-off-by: Armin Wolf <W_Armin@xxxxxx>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/dell-smm-hwmon.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> --
> 2.30.2
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 9cac80358072..01a94b62c2ab 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1356,15 +1356,21 @@ static int __init dell_smm_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, data);
>
> if (dmi_check_system(i8k_blacklist_fan_support_dmi_table)) {
> - dev_warn(&pdev->dev, "broken Dell BIOS detected, disallow fan support\n");
> - if (!force)
> + if (!force) {
> + dev_notice(&pdev->dev, "Disabling fan support due to BIOS bugs\n");
> data->disallow_fan_support = true;
> + } else {
> + dev_warn(&pdev->dev, "Enabling fan support despite BIOS bugs\n");
> + }
> }
>
> if (dmi_check_system(i8k_blacklist_fan_type_dmi_table)) {
> - dev_warn(&pdev->dev, "broken Dell BIOS detected, disallow fan type call\n");
> - if (!force)
> + if (!force) {
> + dev_notice(&pdev->dev, "Disabling fan type call due to BIOS bugs\n");
> data->disallow_fan_type_call = true;
> + } else {
> + dev_warn(&pdev->dev, "Enabling fan type call despite BIOS bugs\n");
> + }
> }
>
> strscpy(data->bios_version, i8k_get_dmi_data(DMI_BIOS_VERSION),
