On 19/08/2022 06:04, Duke Du wrote:
Thank you for your patch. There is something to discuss/improve.
> +static int tps546d24_probe(struct i2c_client *client)
> +{
> + return pmbus_do_probe(client, &tps546d24_info);
> +}
> +
> +static const struct i2c_device_id tps546d24_id[] = {
> + {"tps546d24", 0},
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, tps546d24_id);
> +
> +static const struct of_device_id __maybe_unused tps546d24_of_match[] = {
> + {.compatible = "tps546d24"},
Except missing vendor prefix, you need to document the compatible in
bindings.
> + {}
> +};
> +
Missing MODULE_DEVICE_TABLE
> +MODULE_IMPORT_NS(PMBUS);
Best regards,
Krzysztof
