On Sun, Aug 21, 2022 at 05:17:13PM +0200, Armin Wolf wrote:
> When dell-smm-hwmon is loaded on a machine with a buggy BIOS
> with the option "force" being enabled, it wrongly prints
> what the buggy features where disabled. This may cause
> users to wrongly assume that the driver still protects them
> from these BIOS bugs even with "force" being enabled.
> Change the warning message to avoid such a misunderstanding.
>
> Tested on a Dell Inspiron 3505.
>
> Signed-off-by: Armin Wolf <W_Armin@xxxxxx>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f7bab1a91b93..bf13852afe48 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1354,13 +1354,13 @@ static int __init dell_smm_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, data);
>
> if (dmi_check_system(i8k_blacklist_fan_support_dmi_table)) {
> - dev_warn(&pdev->dev, "broken Dell BIOS detected, disallow fan support\n");
> + dev_warn(&pdev->dev, "BIOS has broken fan support\n");
I don't see that as improvement. It no longer mentions that fan support
is disabled if it is disabled.
> if (!force)
> data->disallow_fan_support = true;
> }
>
> if (dmi_check_system(i8k_blacklist_fan_type_dmi_table)) {
> - dev_warn(&pdev->dev, "broken Dell BIOS detected, disallow fan type call\n");
> + dev_warn(&pdev->dev, "BIOS has broken fan type call\n");
Same as above.
> if (!force)
> data->disallow_fan_type_call = true;
> }
> --
> 2.30.2
>
