On Fri, 19 Aug 2022, Badal Nilawar <badal.nilawar@xxxxxxxxx> wrote: > diff --git a/drivers/gpu/drm/i915/i915_hwmon.h b/drivers/gpu/drm/i915/i915_hwmon.h > new file mode 100644 > index 000000000000..921ae76099d3 > --- /dev/null > +++ b/drivers/gpu/drm/i915/i915_hwmon.h > @@ -0,0 +1,20 @@ > +/* SPDX-License-Identifier: MIT */ > + > +/* > + * Copyright © 2022 Intel Corporation > + */ > + > +#ifndef __I915_HWMON_H__ > +#define __I915_HWMON_H__ > + > +#include <linux/device.h> > +#include <linux/mutex.h> > +#include <linux/types.h> > +#include "i915_reg.h" All of the above #includes are unnecessary. Please remove. BR, Jani. > + > +struct drm_i915_private; > + > +void i915_hwmon_register(struct drm_i915_private *i915); > +void i915_hwmon_unregister(struct drm_i915_private *i915); > + > +#endif /* __I915_HWMON_H__ */ -- Jani Nikula, Intel Open Source Graphics Center
