On Sat, Aug 06, 2022 at 02:46:06PM +0900, Tokunori Ikegami wrote: > NVMe drives support host controlled thermal management feature as optional. > The thermal management temperature are different from the temperature threshold. > So add functionality to set the throttling temperature values. > > Signed-off-by: Tokunori Ikegami <ikegami.t@xxxxxxxxx> NACK. There are several existing limit attributes which can be used for this purpose. I would suggest to use EMERGENCY and LCRIT attributes. Furthermore, one can not just extend the hwmon ABI without discussion, much less as part of a patch introducing its use. Any attribute introduced into the ABI must benefit more than one device, and a matching implementation in the sensors command and the lm-sensors library is expected. Guenter
