Le 29/06/2022 à 09:23, Uwe Kleine-König a écrit : > Hello, > > [I dropped nearly all individuals from the Cc: list because various > bounces reported to be unhappy about the long (logical) line.] Good idea, even patchwork made a mess of it, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220628140313.74984-7-u.kleine-koenig@xxxxxxxxxxxxxx/ > > On Wed, Jun 29, 2022 at 03:03:54PM +0800, Jeremy Kerr wrote: >> Looks good - just one minor change for the mctp-i2c driver, but only >> worthwhile if you end up re-rolling this series for other reasons: >> >>> -static int mctp_i2c_remove(struct i2c_client *client) >>> +static void mctp_i2c_remove(struct i2c_client *client) >>> { >>> struct mctp_i2c_client *mcli = i2c_get_clientdata(client); >>> struct mctp_i2c_dev *midev = NULL, *tmp = NULL; >>> @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client) >>> mctp_i2c_free_client(mcli); >>> mutex_unlock(&driver_clients_lock); >>> /* Callers ignore return code */ >>> - return 0; >>> } >> >> The comment there no longer makes much sense, I'd suggest removing that >> too. > > Yeah, that was already pointed out to me in a private reply. It's > already fixed in > > https://git.pengutronix.de/cgit/ukl/linux/log/?h=i2c-remove-void > >> Either way: >> >> Reviewed-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx> > > Added to my tree, too. > > Thanks > Uwe >
