Re: [PATCH v2] hwmon: (occ) remove NULL check before kvfree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/14/22 06:30, Dongliang Mu wrote:
From: Dongliang Mu <mudongliangabcd@xxxxxxxxx>

kvfree can handle NULL pointer as its argument.
According to coccinelle isnullfree check, remove NULL check
before kvfree operation.

Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>

Actually, it turns out that I already got the same patch
and that it is already applied.

Thanks,
Guenter

---
v1->v2: modify the commit title and signature
  drivers/hwmon/occ/p9_sbe.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/hwmon/occ/p9_sbe.c b/drivers/hwmon/occ/p9_sbe.c
index 42fc7b97bb34..01405ae2f9bd 100644
--- a/drivers/hwmon/occ/p9_sbe.c
+++ b/drivers/hwmon/occ/p9_sbe.c
@@ -55,8 +55,7 @@ static bool p9_sbe_occ_save_ffdc(struct p9_sbe_occ *ctx, const void *resp,
  	mutex_lock(&ctx->sbe_error_lock);
  	if (!ctx->sbe_error) {
  		if (resp_len > ctx->ffdc_size) {
-			if (ctx->ffdc)
-				kvfree(ctx->ffdc);
+			kvfree(ctx->ffdc);
  			ctx->ffdc = kvmalloc(resp_len, GFP_KERNEL);
  			if (!ctx->ffdc) {
  				ctx->ffdc_len = 0;
@@ -171,8 +170,7 @@ static int p9_sbe_occ_remove(struct platform_device *pdev)
  	ctx->sbe = NULL;
  	occ_shutdown(occ);
- if (ctx->ffdc)
-		kvfree(ctx->ffdc);
+	kvfree(ctx->ffdc);
return 0;
  }




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux