Hi,
On 2022/5/11 14:45, Greg KH wrote:
On Wed, May 11, 2022 at 02:49:54PM +0800, Yang Yingliang wrote:
Use kfree_sensitive() instead of open-coding it.
Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
---
drivers/w1/w1.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index f2ae2e563dc5..a0a6c3c739d9 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -73,8 +73,7 @@ static void w1_master_release(struct device *dev)
struct w1_master *md = dev_to_w1_master(dev);
dev_dbg(dev, "%s: Releasing %s.\n", __func__, md->name);
- memset(md, 0, sizeof(struct w1_master) + sizeof(struct w1_bus_master));
- kfree(md);
+ kfree_sensitive(md);
Does this actually change anything? Why is the memset being called here
at all?
It's no functional change and I got this by
scripts/coccinelle/api/kfree_sensitive.cocci.
I'm not sure why using memset() here.
Thanks,
Yang
thanks,
greg k-h
.
