Re: [PATCH 1/2] dt-bindings: add extended-range-enable property to lm90.yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/10/22 00:19, Holger Brunck wrote:
On 5/9/22 06:10, Holger Brunck wrote:
Add a boolean extended-range-enable to make the extented temperature
feature for some lm90 devices configurable.

Signed-off-by: Holger Brunck <holger.brunck@xxxxxxxxxxxxxxxxx>
cc: Jean Delvare <jdelvare@xxxxxxxx>
cc: Guenter Roeck <linux@xxxxxxxxxxxx>
cc: Rob Herring <robh+dt@xxxxxxxxxx>
cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
---
   Documentation/devicetree/bindings/hwmon/national,lm90.yaml | 4 ++++
   1 file changed, 4 insertions(+)

diff --git
a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
index 30db92977937..98d01f6c9331 100644
--- a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
+++ b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
@@ -52,6 +52,10 @@ properties:
     vcc-supply:
       description: phandle to the regulator that provides the +VCC
supply

+  extended-range-enable:

This should probably be either "onsemi,extended-range-enable" (for
adt7461) or "ti,extended-range-enable" (for the supported TI chips).


I can change that, but I thought a generic name would be better as the
same property name is already used in drivers/hwmon/max6697.c.


That was introduced at times when things were not always reviewed
by DT maintainers, and was wrong. I'd be open to change that to
maxim,extended-range-enable (it isn't used in any upstream or published
DT file). Let's wait for Rob or Krzysztof to decide.

Guenter



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux