Hi Quan, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on groeck-staging/hwmon-next lee-mfd/for-mfd-next v5.18-rc3 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220422-105732 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git c50c29a806113614098efd8da9fd7b48d605ba45 config: arm-randconfig-r004-20220422 (https://download.01.org/0day-ci/archive/20220423/202204230554.4528TqPu-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5bd87350a5ae429baf8f373cb226a57b62f87280) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/09ec873f0dd4611cb2df0150923d8906b9c5b2d1 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220422-105732 git checkout 09ec873f0dd4611cb2df0150923d8906b9c5b2d1 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/mach-at91/ drivers/hwmon/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/hwmon/smpro-hwmon.c:376:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ drivers/hwmon/smpro-hwmon.c:376:3: note: insert 'break;' to avoid fall-through default: ^ break; 1 warning generated. vim +376 drivers/hwmon/smpro-hwmon.c e1354080fc83378 Quan Nguyen 2022-04-22 359 e1354080fc83378 Quan Nguyen 2022-04-22 360 static umode_t smpro_is_visible(const void *data, enum hwmon_sensor_types type, e1354080fc83378 Quan Nguyen 2022-04-22 361 u32 attr, int channel) e1354080fc83378 Quan Nguyen 2022-04-22 362 { e1354080fc83378 Quan Nguyen 2022-04-22 363 const struct smpro_hwmon *hwmon = data; e1354080fc83378 Quan Nguyen 2022-04-22 364 unsigned int value; e1354080fc83378 Quan Nguyen 2022-04-22 365 int ret; e1354080fc83378 Quan Nguyen 2022-04-22 366 e1354080fc83378 Quan Nguyen 2022-04-22 367 switch (type) { e1354080fc83378 Quan Nguyen 2022-04-22 368 case hwmon_temp: e1354080fc83378 Quan Nguyen 2022-04-22 369 switch (attr) { e1354080fc83378 Quan Nguyen 2022-04-22 370 case hwmon_temp_input: e1354080fc83378 Quan Nguyen 2022-04-22 371 case hwmon_temp_label: e1354080fc83378 Quan Nguyen 2022-04-22 372 case hwmon_temp_crit: e1354080fc83378 Quan Nguyen 2022-04-22 373 ret = regmap_read(hwmon->regmap, temperature[channel].reg, &value); e1354080fc83378 Quan Nguyen 2022-04-22 374 if (ret || value == 0xFFFF) e1354080fc83378 Quan Nguyen 2022-04-22 375 return 0; e1354080fc83378 Quan Nguyen 2022-04-22 @376 default: e1354080fc83378 Quan Nguyen 2022-04-22 377 break; e1354080fc83378 Quan Nguyen 2022-04-22 378 } e1354080fc83378 Quan Nguyen 2022-04-22 379 break; e1354080fc83378 Quan Nguyen 2022-04-22 380 default: e1354080fc83378 Quan Nguyen 2022-04-22 381 break; e1354080fc83378 Quan Nguyen 2022-04-22 382 } e1354080fc83378 Quan Nguyen 2022-04-22 383 e1354080fc83378 Quan Nguyen 2022-04-22 384 return 0444; e1354080fc83378 Quan Nguyen 2022-04-22 385 } e1354080fc83378 Quan Nguyen 2022-04-22 386 -- 0-DAY CI Kernel Test Service https://01.org/lkp
