Re: [PATCH 1/2] dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/12/22 13:53, Krzysztof Kozlowski wrote:
On 11/04/2022 12:03, Camel Guo wrote:
From: Camel Guo <camelg@xxxxxxxx>

Document the TMP401, TMP411 and TMP43x device devicetree bindings

Signed-off-by: Camel Guo <camelg@xxxxxxxx>
---
  .../devicetree/bindings/hwmon/ti,tmp401.yaml  | 111 ++++++++++++++++++
  MAINTAINERS                                   |   1 +
  2 files changed, 112 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml


+      - ti,tmp401
+      - ti,tmp411
+      - ti,tmp431
+      - ti,tmp432
+      - ti,tmp435

Blank line, please.

Fixed

+  reg:
+    maxItems: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0
+
+  ti,extended-range-enable:
+    description: |

No need for "|". Here and in most of other cases below.

Fixed


+      When set, this sensor measures over extended temperature range.
+    type: boolean
+
+  ti,n-factor:
+    description: |
+      The value (two's complement) to be programmed in the n-factor correction
+      register.

Do not describe the programming model (registers) but hardware property
instead.

Make another try. Hope it is clear now.

+    $ref: /schemas/types.yaml#/definitions/uint32
+    items:
+      minimum: 0
+      maximum: 255
+
+  ti,beta-compensation:
+    description: |
+      The value to be programmed in the beta range register.

The same, register values should not be stored in DT.

+    $ref: /schemas/types.yaml#/definitions/uint32
+    items:
+      minimum: 0
+      maximum: 15
+


Best regards,
Krzysztof

Fixed in v2. Please review that instead.



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux