On 2/26/22 07:09, Aleksa Savic wrote:
Hi,
On Thu, Feb 24, 2022 at 11:57:47AM -0800, Guenter Roeck wrote:
Hi,
On 2/21/22 02:21, Aleksa Savic wrote:
This driver exposes hardware temperature sensors of the Aquacomputer
Farbwerk 360 RGB controller, which communicates through a proprietary
USB HID protocol.
Four temperature sensors are available. If a sensor is not connected,
it will report zeroes. Additionally, serial number and firmware version
are exposed through debugfs.
This driver has been tested on x86_64.
Signed-off-by: Aleksa Savic <savicaleksa83@xxxxxxxxx>
Unless I amm missing something, this driver is quite similar to the
d5next driver (drivers/hwmon/aquacomputer_d5next.c), except that there
are 4 instead of 1 temperature sensor, the sensor data is in a different place,
and there is _only_ temperature data. It should be quite straightforward
to merge the two drivers into one, so please do that.
Additional comment inline.
Thanks,
Guenter
Yes, it's very similar, I based this one on that. I'll send a patch for
the original driver. I also have code ready for Aquacomputer Octo (8 fans, 4
temperature sensors, very similar to all this as well) with PWM write control
support for the fans. And there is also WIP code for PWM and curve support for
the D5 Next from contributors on my github repo, though we're working on that.
Considering that the driver would then contain support for more devices (the D5
Next and the Farbwerk 360 for now), can it be renamed to just aquacomputer or
something similar?
We don't normally do that (because the Kconfig symbol is already established)
and just name the driver for the first chip (or, in this case, controller)
it supports.
Guenter
