Re: [PATCH 2/2] dt-bindings: hwmon: Add sample averaging property for ADM1275

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/23/22 08:38, Potin Lai wrote:
Add binding information for "pwr-avg" and "vi-avg" properties

Signed-off-by: Potin Lai <potin.lai@xxxxxxxxxxxx>
---
  .../devicetree/bindings/hwmon/adi,adm1275.yaml         | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
index 223393d7cafd..2525a67a880e 100644
--- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
+++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
@@ -37,6 +37,14 @@ properties:
      description:
        Shunt resistor value in micro-Ohm.
+ vi-avg:
+    description:
+      Sample averaging for current and voltage.
+
+  pwr-avg:
+    description:
+      Sample averaging for power.
+

Properties need a better name, prefixed with chip vendor, and the valid range
needs to be provided. Also, the description could be better, eg "Number of samples
to be used to report power values". Also, the chips actually supporting power
sampling need to be listed.

Guenter

  required:
    - compatible
    - reg
@@ -53,5 +61,7 @@ examples:
              compatible = "adi,adm1272";
              reg = <0x10>;
              shunt-resistor-micro-ohms = <500>;
+            vi-avg = <128>;
+            pwr-avg = <128>;
          };
      };




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux