On Thu, 17 Feb 2022 at 19:26, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > Looks like you did not run checkpatch. I did (0 errors/warnings/checks). What needs to be corrected? > Either case, I think you should just drop this function In probe: Yes, currently that function is tiny, but some tests with motherboards from other families are done by users and if I add other families, the information required for each board model will grow and in that case I'd switch from dmi_system_id array to a custom struct to define all the board-related data at at the same place, and to save some space in the module binary, as unused parts of the dmi_system_id array already take a quarter of the total binary size. So, the function will likely get some more code soon. Regards, Eugene
