Hi-- On 2/7/22 10:29, Mateusz Jończyk wrote: > It is not the laptops, but the /proc/i8k interface that is legacy. The > old description was confusing, fix this. > > I'm not a native English speaker, so I'd like that someone proofread > this description. > > Signed-off-by: Mateusz Jończyk <mat.jonczyk@xxxxx> > Cc: Pali Rohár <pali@xxxxxxxxxx> > Cc: Jean Delvare <jdelvare@xxxxxxxx> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx> > Cc: Mark Gross <markgross@xxxxxxxxxx> > --- > drivers/hwmon/Kconfig | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index dd244aa747ad..8f9f41a9ef70 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -506,18 +506,17 @@ config SENSORS_DELL_SMM > userspace interface for i8kutils package. > > config I8K > - bool "Dell i8k legacy laptop support" > + bool "Legacy /proc/i8k interface of Dell laptop SMM BIOS hwmon driver" > depends on SENSORS_DELL_SMM > help > - This option enables legacy /proc/i8k userspace interface in hwmon > - dell-smm-hwmon driver. Character file /proc/i8k reports bios version, > - temperature and allows controlling fan speeds of Dell laptops via > - System Management Mode. For old Dell laptops (like Dell Inspiron 8000) > - it reports also power and hotkey status. For fan speed control is > - needed userspace package i8kutils. > + This option enables the legacy /proc/i8k userspace interface of the > + dell-smm-hwmon driver. The character file /proc/i8k exposes the BIOS > + version, temperatures and allows control of fan speeds of some Dell > + laptops. Sometimes, it reports also power and hotkey status. Comma not needed ^^^; "it also reports ..." would be more common. > > - Say Y if you intend to run this kernel on old Dell laptops or want to > - use userspace package i8kutils. > + This interface is required to run programs from the i8kutils package. > + > + Say Y if you intend to run userspace programs that use this interface. > Say N otherwise. > > config SENSORS_DA9052_ADC thanks. -- ~Randy
