11.01.2022 19:51, Guenter Roeck пишет:
> sysfs and udev notifications need to be sent to the _alarm
> attributes, not to the value attributes.
>
> Fixes: 94dbd23ed88c ("hwmon: (lm90) Use hwmon_notify_event()")
> Cc: Dmitry Osipenko <digetx@xxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/hwmon/lm90.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
> index ba01127c1deb..1c9493c70813 100644
> --- a/drivers/hwmon/lm90.c
> +++ b/drivers/hwmon/lm90.c
> @@ -1808,22 +1808,22 @@ static bool lm90_is_tripped(struct i2c_client *client, u16 *status)
>
> if (st & LM90_STATUS_LLOW)
> hwmon_notify_event(data->hwmon_dev, hwmon_temp,
> - hwmon_temp_min, 0);
> + hwmon_temp_min_alarm, 0);
> if (st & LM90_STATUS_RLOW)
> hwmon_notify_event(data->hwmon_dev, hwmon_temp,
> - hwmon_temp_min, 1);
> + hwmon_temp_min_alarm, 1);
> if (st2 & MAX6696_STATUS2_R2LOW)
> hwmon_notify_event(data->hwmon_dev, hwmon_temp,
> - hwmon_temp_min, 2);
> + hwmon_temp_min_alarm, 2);
> if (st & LM90_STATUS_LHIGH)
> hwmon_notify_event(data->hwmon_dev, hwmon_temp,
> - hwmon_temp_max, 0);
> + hwmon_temp_max_alarm, 0);
> if (st & LM90_STATUS_RHIGH)
> hwmon_notify_event(data->hwmon_dev, hwmon_temp,
> - hwmon_temp_max, 1);
> + hwmon_temp_max_alarm, 1);
> if (st2 & MAX6696_STATUS2_R2HIGH)
> hwmon_notify_event(data->hwmon_dev, hwmon_temp,
> - hwmon_temp_max, 2);
> + hwmon_temp_max_alarm, 2);
IIUC, "alarm" is about the T_CRIT output line. While these attributes
are about the ALERT line. Hence why "alert" notifications need to be
sent to the unrelated "alarm" attributes? This change doesn't look right.
