Re: [PATCH v5 3/3] hwmon: deprecate asis_wmi_ec_sensors driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/12/22 1:51 PM, Oleksandr Natalenko wrote:
Hello.

On úterý 11. ledna 2022 19:03:46 CET Eugene Shalygin wrote:
---
  drivers/hwmon/Kconfig | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 2c16b19d2c03..5e693c93d43a 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -2243,13 +2243,16 @@ config SENSORS_ASUS_WMI
config SENSORS_ASUS_WMI_EC
  	tristate "ASUS WMI B550/X570"
-	depends on ACPI_WMI
+	depends on ACPI_WMI && !SENSORS_ASUS_EC

Not sure how it handles `SENSORS_ASUS_EC=m`. Probably, it should be:

```
depends on ACPI_WMI && SENSORS_ASUS_EC=n
```


Odd language, and good catch. If I understand correctly, the result
of !SENSORS_ASUS_EC is 'm' if SENSORS_ASUS_EC=m. So, yes, it looks
like this needs to be "ACPI_WMI && SENSORS_ASUS_EC=n".

Guenter

?

  	help
  	  If you say yes here you get support for the ACPI embedded controller
  	  hardware monitoring interface found in B550/X570 ASUS motherboards.
  	  This driver will provide readings of fans, voltages and temperatures
  	  through the system firmware.
+ This driver is deprecated in favor of the ASUS EC Sensors driver
+	  which provides fully compatible output.
+
  	  This driver can also be built as a module. If so, the module
  	  will be called asus_wmi_sensors_ec.

Thanks.





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux