On 12/16/21 2:22 PM, Denis Pauk wrote:
Hi, Could you please provide a some feedback about such idea? I have bigger list of supported boards that requires ACPI mutex lock, but I prefer to have some feedback before send next version of patch. I have created separate patch[1] with only boards where WMI methods is enough. And if work on patch takes some time/additional patch versions(for sure it will), I prefer to have that patch merged and rebase current patch over resulted list of boards.
Looking through the code, I am absolutely not happy with it. It makes the driver even more unreadable than it already is, and on top of that makes it vulnerable to problems in the ACPI code. Example: If ACPI fails to unlock the mutex, the driver will end up being non-functional. At some point, we have to face it: ASUS doesn't support Linux, and they make it hard to access chips like this. I think the chip should be accessed through "official" channels only if provided (ie WMI/ACPI), or not at all. Guenter
