On Tue, Dec 07, 2021 at 06:45:47AM +0000, Joel Stanley wrote: > Hi Billy, > > On Tue, 30 Nov 2021 at 05:58, Billy Tsai <billy_tsai@xxxxxxxxxxxxxx> wrote: > > > > The legacy driver of aspeed pwm is binding with tach controller and it > > doesn't follow the pwm framworks usage. In addition, the pwm register > > usage of the 6th generation of ast26xx has drastic change. So these > > patch serials add the new aspeed pwm driver to fix up the problem above. > > Sorry for not taking a look earlier. Well done on making it this far. > > There's a few things that need to be addressed before merging this. > > Firstly, the bindings need fixing up. I think these should be the one > file. The device tree bindings are supposed to describe the hardware, > and it doesn't make sense to separate them out just because we plan on > using two subsystems to implement the functionality. > > Rob, please chime in if you would prefer something different. I prefer to see a common binding for fans which I said multiple times on this series. As the same thing keeps getting posted, I've stopped looking at this one. Rob
